Merge pull request #124 from thbeu/fix-cppcheck-issues

Fix issues reported by cppcheck 2.13.0
OSGeo · Mar 25, 2024 · 2b0c097 · 2b0c097
2 parents f04a4b3 + 4a0fb2d
commit 2b0c097
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/dbfopen.c b/dbfopen.c
@@ -2146,7 +2146,6 @@ int SHPAPI_CALL DBFAlterFieldDefn(DBFHandle psDBF, int iField,
         char *pszOldField =
             STATIC_CAST(char *, malloc(sizeof(char) * (nOldWidth + 1)));
 
-        /* cppcheck-suppress uninitdata */
         pszOldField[nOldWidth] = 0;
 
         /* move records to their new positions */
@@ -2224,7 +2223,6 @@ int SHPAPI_CALL DBFAlterFieldDefn(DBFHandle psDBF, int iField,
         char *pszOldField =
             STATIC_CAST(char *, malloc(sizeof(char) * (nOldWidth + 1)));
 
-        /* cppcheck-suppress uninitdata */
         pszOldField[nOldWidth] = 0;
 
         /* move records to their new positions */

diff --git a/shpopen.c b/shpopen.c
@@ -1244,8 +1244,7 @@ SHPObject SHPAPI_CALL1(*)
                 psObject->panPartType[i] = SHPP_RING;
         }
 
-        if (psObject->panPartStart[0] != 0)
-            psObject->panPartStart[0] = 0;
+        psObject->panPartStart[0] = 0;
     }
 
     /* -------------------------------------------------------------------- */