Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database: update to EPSG v11.025 #4350

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Database: update to EPSG v11.025 #4350

merged 2 commits into from
Dec 14, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 13, 2024

@jratike80 This EPSG release brings finally the Finland geoid models (and bonus points as GTG files). Is there going to be a pull request against https://github.com/OSGeo/PROJ-data/ to add the grids?

@rouault rouault added this to the 9.6.0 milestone Dec 13, 2024
@rouault rouault added the funded through GSP Work funded through the GDAL Sponsorship Program label Dec 13, 2024
@jjimenezshaw
Copy link
Contributor

@jratike80 This EPSG release brings finally the Finland geoid models (and bonus points as GTG files). Is there going to be a pull request against https://github.com/OSGeo/PROJ-data/ to add the grids?

I started it some time ago. I can search that branch somewhere in my computer.

@jratike80
Copy link

@jjimenezshaw , do you have the geoid models in tiff format (fi_nls_fin2023n2000.tif, fi_nls_fin2000.tif)? I have some self-made versions which I converted from ASCII but they are not checked.
I do not know is Pasi Häkli has GitHub account but I can try to reach him per email.

@jjimenezshaw
Copy link
Contributor

@jratike80 I did this some time ago
jjimenezshaw/PROJ-data@72eb6fa
I can review it tomorrow

@kbevers
Copy link
Member

kbevers commented Dec 13, 2024

I do not know is Pasi Häkli has GitHub account but I can try to reach him per email.

He does: @phakli

@rouault rouault changed the title Database: update to EPSG v11.024 Database: update to EPSG v11.025 Dec 14, 2024
@jjimenezshaw
Copy link
Contributor

I am updating the scripts of my branch to include also fi_nls_fin2023n2000.tif, and declare they use EUREF-FIN (EPSG:10689).
Once this PR (#4350) is merged I will continue with it; I need EPSG:10689 in proj.db

To convert the ASCII files (*.lst) I am using the same workflow as usualy, with a bash script included in the branch. You can already have a look.

@rouault rouault merged commit 387f442 into OSGeo:master Dec 14, 2024
25 checks passed
@jjimenezshaw
Copy link
Contributor

jjimenezshaw commented Dec 15, 2024

Interestingly, the projected system EPSG:3067, previously named ETRS89 / TM35FIN(E,N) is now EUREF-FIN / TM35FIN(E,N), changing not only the name, but the base CRS. (EUREF-FIN is a realization of ETRS89)

And this is one of those CRSs with two areas of use.

@jratike80
Copy link

Right, when the EUREF-FIN datum was added https://epsg.org/datum_1391/EUREF-FIN.html, there were two alternatives. Either to register a new set of CRS codes for EUREF-FIN, or to edit the definitions of the existing codes. There are quite many codes affected https://epsg.org/closed-change-request/browse/id/[2024.062](https://epsg.org/closed-change-request/browse/id/2024.062).

Some confusion is inevident but we considered that most users who use the established EPSG:3067 etc. will not suffer from the base CRS change.

@phakli
Copy link

phakli commented Dec 16, 2024

Glad to see that the inclusion of the Finnish geoid models to PROJ is already in progress, thanks @jjimenezshaw. That would've been our next task. I had already started testing with some self-converted gtg files but they were not produced according to PROJ contributing guidelines yet. And, as we are novices with contributing to PROJ, we were only about to start checking the guidelines. So, to make things right and faster, we appreciate and support your efforts. We can help as much as we can, at least testing the grids and checking the information if needed.

By the way, IOGP has also included our TINshift-based transformations to EPSG registry, see EPSG:10703-10705. Is there something we should do with these regarding the PROJ?

@jjimenezshaw
Copy link
Contributor

@phakli There is already a PR with the grid files at OSGeo/PROJ-data#131
please, check them and the metadata.
If you compile "master" branch from PROJ (that includes the latest version of EPSG) and use those grid files, it should work directly.

@jratike80
Copy link

Hi,

I checked the TIFF files with gdalinfo. Pixel sizes, extents, and metadata tags look good to me. I believe that MMT here means MML (MaanMittausLaitos). MMT refers usually to Doctor of Agriculture and Forestry. But maybe MML would not add any value, while the full name National Land Survey of Finland might do that.

TIFFTAG_COPYRIGHT=Derived from work by NLS (MMT) Finland. CC-BY-4.0 https://creativecommons.org/licenses/by/4.0/

@jjimenezshaw
Copy link
Contributor

Hi,

I checked the TIFF files with gdalinfo. Pixel sizes, extents, and metadata tags look good to me. I believe that MMT here means MML (MaanMittausLaitos). MMT refers usually to Doctor of Agriculture and Forestry. But maybe MML would not add any value, while the full name National Land Survey of Finland might do that.

TIFFTAG_COPYRIGHT=Derived from work by NLS (MMT) Finland. CC-BY-4.0 https://creativecommons.org/licenses/by/4.0/

@jratike80 Answered in OSGeo/PROJ-data#131

@rouault
Copy link
Member Author

rouault commented Dec 16, 2024

By the way, IOGP has also included our TINshift-based transformations to EPSG registry, see EPSG:10703-10705. Is there something we should do with these regarding the PROJ?

support for them queued in #4353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants