FDP-2359: command handling reboot

[loesimmens]

No description provided.

[smvdheijden]

Would it be possible to use regex pattern matchers instead of parts?

[loesimmens]

Refactored a bit, but without regex. Do you have a regex suggestion that improves on this?

[smvdheijden]

This test method should probably be moved to a different class, as it has nothing to do with handling coap messages?

[smvdheijden]

Consider adding a separate TestConstants class for the shared test constants.

[smvdheijden]

I think I might prefer one of these possible alternatives without using recursive comparison:

• with checks on type and message:

        assertThatThrownBy { CommandMapper.externalCommandToCommandEntity(externalCommand, status) }
            .isInstanceOf(CommandValidationException::class.java)
            .hasMessage("Command unknown: ${externalCommand.command}")

• with (likely) increased readability:

        assertThatExceptionOfType(CommandValidationException::class.java)
            .isThrownBy { CommandMapper.externalCommandToCommandEntity(externalCommand, status) }
            .withMessage("Command unknown: ${externalCommand.command}")

• with a clearer distinction between "act" and "assert":

        val actual = catchThrowable {
            CommandMapper.externalCommandToCommandEntity(externalCommand, status)
        }

        assertThat(actual)
            .isInstanceOf(CommandValidationException::class.java)
            .hasMessage("Command unknown: ${externalCommand.command}")

[loesimmens]

mooier inderdaad

[smvdheijden]

You could even reduce this to:

        assertThatIllegalArgumentException().isThrownBy {
            CommandMapper.commandNameToType("invalid")
        }

or more verbose with a clearer distinction between the "triple A" sections ("arrange, "act", and "assert")

    val commandName = "invalid"

    val actual = catchThrowable { CommandMapper.commandNameToType(commandName) }

    assertThat(actual).isInstanceOf(IllegalArgumentException::class.java)
  

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud