Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments about building with shared libraries #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ Python bindings for [`opm-simulators`](https://github.com/OPM/opm-simulators) an

## To build opm-python

- Note that we are not able to build with shared libraries yet, see https://github.com/OPM/opm-simulators/issues/5390.

- We need to enable embedded Python in `opm-common` in order to run the `PYACTION` test cases.

- Build script:
Expand All @@ -21,7 +19,7 @@ do
done

build_opm_common() {
local flags="-DBUILD_SHARED_LIBS=OFF -DOPM_ENABLE_PYTHON=ON -DOPM_ENABLE_EMBEDDED_PYTHON=ON"
local flags="-DOPM_ENABLE_PYTHON=ON -DOPM_ENABLE_EMBEDDED_PYTHON=ON"
cd opm-common
mkdir build
cd build
Expand All @@ -31,7 +29,7 @@ build_opm_common() {
}

build_opm_grid() {
local flags="-DBUILD_SHARED_LIBS=OFF"
local flags=""
cd opm-grid
mkdir build
cd build
Expand All @@ -41,7 +39,7 @@ build_opm_grid() {
}

build_opm_models() {
local flags="-DBUILD_SHARED_LIBS=OFF"
local flags=""
cd opm-models
mkdir build
cd build
Expand All @@ -51,7 +49,7 @@ build_opm_models() {
}

build_opm_simulators() {
local flags="-DBUILD_SHARED_LIBS=OFF"
local flags=""
cd opm-simulators
mkdir build
cd build
Expand Down