Adjoint new try #512
Draft
Adjoint new try #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added comment on probable wrong behavoir of deserialize which also is restart spesific Added grid name in restart
commented probably unwanted code
…retinging of consepts of derivatives...
…oms not using eclproblem.hh
…: maybe a setEnableStoargeCache should be reintroduced in the simulator
…pology of wells is changing:
…ith focusTimeIdex=1
…/ewoms into hnil-merge_master_rebase_adjoint
This makes the code compile also when the local Evaluation type is double.
For adjoint backwards run, this logic is wrong. Flow provides its own timesteps anyway, so disabling it for Flow allows all existing ewoms tests to succeed, while allowing adjoint runs.
Update adjoint ewoms code
…o adjoint_new_try
…w_try tryied to merge again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the old pull request into master. It compile and seems to run all tests. Parallel testing not done.
This facilitate the adjoint work. A more general approach than focusTimeIdx index will facilitate
sequential solves with minimal change to the core of the simulator. (This will be left to after the adjoint is merged).
This will be followed by pullrequest in opm-simulator and opm-tests