Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyhedralGrid: use MPIHelper's default communicator for CollectiveCommunication. #431

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dr-robertk
Copy link
Member

This fixes a compilation issue with ebos.

@dr-robertk
Copy link
Member Author

jenkins build this please

@dr-robertk
Copy link
Member Author

Any objections of this being merged?

@@ -130,26 +135,24 @@ namespace Dune
PolyhedralGridBasicGeometry ( ExtraData data, const EntitySeed& seed )
: storage_( data, seed )
{
GeometryType myType = type();
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important to keep the commented-out code?

I do not mind merging this when Jenkins is green.

@dr-robertk
Copy link
Member Author

jenkins build this please

@dr-robertk
Copy link
Member Author

@atgeirr: I removed the unused code.

@dr-robertk
Copy link
Member Author

jenkins build this please

@blattms
Copy link
Member

blattms commented Dec 18, 2019

The test of polyhedralgrid fails due to a degenerated element (volume near zero).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants