Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TEMP option #4411

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Implement TEMP option #4411

wants to merge 2 commits into from

Conversation

totto82
Copy link
Member

@totto82 totto82 commented Jan 8, 2025

  • always store temperature in the fluidstate
  • use the enableTemperature flag for simulations where the temperature is solved sequentially

@totto82 totto82 marked this pull request as draft January 8, 2025 13:55
@totto82 totto82 mentioned this pull request Jan 8, 2025
Draft
@totto82
Copy link
Member Author

totto82 commented Jan 8, 2025

jenkins build this opm-simulators=5854 please

@atgeirr
Copy link
Member

atgeirr commented Jan 9, 2025

Are the THERMAL and TEMP options intended to be mutually exclusive? If so, we should not have independent flags for them (and accessors) at this level, instead we should have a single member and accessor, using something like

enum class EnergyModel
{
    Implicit,   // THERMAL keyword
    Sequential, // TEMP keyword
    None        // Neither THERMAL nor TEMP
}

@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

Are the THERMAL and TEMP options intended to be mutually exclusive?

Yes. Your suggestion sound like a good idea. I will first prioritize to make everything compile and tests to pass

@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

jenkins build this opm-simulators=5854 please

9 similar comments
@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 9, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 10, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 10, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 10, 2025

jenkins build this opm-simulators=5854 please

@totto82
Copy link
Member Author

totto82 commented Jan 10, 2025

jenkins build this opm-simulators=5854 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totto82 @atgeirr