Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "dummy" water phase to compositional fluid system #4410

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

svenn-t
Copy link
Contributor

@svenn-t svenn-t commented Jan 8, 2025

The compositional fluid system is expanded to three phases where the water phase is a "dummy"/immiscible phase. Water phase properties are given through PVT functions the same way as in the black oil fluid system.

@svenn-t svenn-t marked this pull request as ready for review January 9, 2025 11:34
@totto82 totto82 requested a review from GitPaean January 14, 2025 14:16
@GitPaean
Copy link
Member

Thanks for the work. I will look into the PRs soon.

@GitPaean
Copy link
Member

jenkins build this opm-simulators=5851 please

@svenn-t
Copy link
Contributor Author

svenn-t commented Jan 16, 2025

After discussion with @totto82 we agreed to have both two-phase and three-phase versions of the compositional fluid system. So I will make this and the opm-simulators PR drafts again and to make the necessary changes.

@svenn-t svenn-t marked this pull request as draft January 16, 2025 10:39
@GitPaean
Copy link
Member

After discussion with @totto82 we agreed to have both two-phase and three-phase versions of the compositional fluid system. So I will make this and the opm-simulators PR drafts again and to make the necessary changes.

I agree and it is appreciated. And depending the testing example you have, you can create the flowexp_comp executable for that specific number of component only first.

Still thinking how to avoid too many exectubales to compile but it can be for later optimization.

@svenn-t svenn-t force-pushed the dummy_water_compositional branch from 1316ad5 to fb16da4 Compare January 20, 2025 11:57
@svenn-t
Copy link
Contributor Author

svenn-t commented Jan 20, 2025

I have updated this PR and OPM/opm-simulators#5851 to have both two- and three-phase versions of the compositional simulator. I did make new executables for two-phase versions of the simulators and they will be run if WATER is present in RUNSPEC.

@svenn-t svenn-t marked this pull request as ready for review January 20, 2025 12:15
@svenn-t svenn-t force-pushed the dummy_water_compositional branch from fb16da4 to 3bcaf72 Compare January 21, 2025 12:49
@totto82
Copy link
Member

totto82 commented Jan 23, 2025

jenkins build this opm-simulators=5851 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants