-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "dummy" water phase to compositional fluid system #4410
base: master
Are you sure you want to change the base?
Conversation
Thanks for the work. I will look into the PRs soon. |
jenkins build this opm-simulators=5851 please |
After discussion with @totto82 we agreed to have both two-phase and three-phase versions of the compositional fluid system. So I will make this and the opm-simulators PR drafts again and to make the necessary changes. |
I agree and it is appreciated. And depending the testing example you have, you can create the flowexp_comp executable for that specific number of component only first. Still thinking how to avoid too many exectubales to compile but it can be for later optimization. |
1316ad5
to
fb16da4
Compare
I have updated this PR and OPM/opm-simulators#5851 to have both two- and three-phase versions of the compositional simulator. I did make new executables for two-phase versions of the simulators and they will be run if |
fb16da4
to
3bcaf72
Compare
jenkins build this opm-simulators=5851 please |
The compositional fluid system is expanded to three phases where the water phase is a "dummy"/immiscible phase. Water phase properties are given through PVT functions the same way as in the black oil fluid system.