Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LGR, NNC and dual porosity support #4407

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Jan 7, 2025

This pull request includes several changes to improve support for LGR, NNC and dual porosity models.

A commit with only clang-format changes is included to clearly see the introduced changes.

Enhancements to Grid Data Handling:

  • Added new member variables nncg_array_index and nncl_array_index to the EGrid
  • Introduced methods load_nnc_data and nnc_connections to load and manage NNC data, ensuring consistency between grid and init files.
  • Added overload of getCellCorners to be able to read out coordinates without radial coordinate conversion.

Improvements to Active Cell Management:

  • Added the set_active_cells method to manage active and fracture active cells, and introduced active_frac_index and ijk_from_active_frac_index methods for handling fracture active cells.

magnesj and others added 5 commits January 7, 2025 11:12
Add convenience function used to extract the cell coordinates without performing the radial coordinate transformation. This is used in ResInsight to improve the visual appearance of radial grid cell. The outer most LGR cells are stretched to completely fill the space of the host cell.

Co-authored-by: Jon Jenssen <[email protected]>
@magnesj
Copy link
Member Author

magnesj commented Jan 10, 2025

I see that there has been some work related to producing LGRs from OpmFlow (like this one #4393). This PR enables import of LGRs and is currently used in a custom branch of opm-common in ResInsight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant