GPU PiecewiseLinearTwoPhaseMaterialParams maintenance and bugfix #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multitalentloes
changed the title
|
Jenkins build this please |
Finalization is adjusted to avoid the cpu accessing values from gpumemory, in particular a mutable buffer.
|
Jenkins build this please |
kjetilly
approved these changes
Jan 8, 2025
opm/material/fluidmatrixinteractions/PiecewiseLinearTwoPhaseMaterialParams.hpp
Outdated
Show resolved
Hide resolved
bska
reviewed
Jan 8, 2025
opm/material/fluidmatrixinteractions/PiecewiseLinearTwoPhaseMaterialParams.hpp
Outdated
Show resolved
Hide resolved
multitalentloes
force-pushed
the
fix_gpu_linear_two_phase_material
branch
from
5a217b2 to
ea29426
Compare
|
jenkins build this opm-simulators=5838 please |
bska
approved these changes
Jan 10, 2025
|
Jenkins build this please |
|
jenkins build this opm-simulators=5838 please |
|
next time, you should not merge anything with commit messages like 'WIP'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalization is adjusted to avoid the cpu accessing values from gpumemory, in particular, a mutable buffer. Avoiding the finalization for the GPU instances is less robust, solutions to this are welcome.
move_to_gpu is added to
PiecewiseLinearTwoPhaseMaterialParamsto make managament of GPU instances easier, and design more consistent with other classes.