Adds support for the DUMPCUPL keyword #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this opm-simulators=5620 please |
Okay. In that case I'll set the PR to draft state in order to avoid inadvertently merging the work before the upstream PR is in the master sources. |
hakonhagland
force-pushed
the
dump_cupl
branch
from
00f9f20 to
16dbcc6
Compare
hakonhagland
force-pushed
the
dump_cupl
branch
from
16dbcc6 to
6b29ecc
Compare
Adds support for the RCMASTS keyword.
hakonhagland
force-pushed
the
dump_cupl
branch
from
e200348 to
2ca83a3
Compare
|
@blattms Thanks for the review. I have added two commits to address the comments. |
|
jenkins build this opm-simulators=5620 please |
|
did build with companion PR in opm-simulators, trying without. |
|
jenkins build this please |
|
Thanks a lot for the changes and the work in total. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4272 which should be merged first.
Adds support for the DUMPCUPL keyword in reservoir coupling.