Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SLAVES keyword #4114

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add support for SLAVES keyword #4114

merged 1 commit into from
Jun 24, 2024

Conversation

hakonhagland
Copy link
Contributor

@hakonhagland hakonhagland commented Jun 20, 2024

See downstream OPM/opm-simulators#5436 for more information.

@hakonhagland
Copy link
Contributor Author

jenkins build this opm-simulators=5436 please

Copy link
Member

@totto82 totto82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged when the relative path is changed

#include "ReservoirCouplingKeywordHandlers.hpp"
#include "ReservoirCouplingInfo.hpp"
#include "../HandlerContext.hpp"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we try to avoid relative paths

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case it's correct since HandlerContext.hpp is a private header.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

@totto82 totto82 merged commit 41bd16f into OPM:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants