FF-A VM availability messages #6958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balint-dobszay-arm
force-pushed
the
vm-msg
branch
from
8302e60
to
ac591fa
Compare
core/arch/arm/kernel/thread_spmc.c
Outdated
| @@ -523,6 +523,10 @@ TEE_Result spmc_fill_partition_entry(uint32_t ffa_vers, void *buf, size_t blen, | |||
|
|
|||
| fpi->partition_properties = part_props; | |||
|
|
|||
| /* In FF-A 1.0 only bits [2:0] are defined, let's mask others */ | |||
| if (ffa_vers < FFA_VERSION_1_1) | |||
| fpi->partition_properties &= 0x07; | |||
There was a problem hiding this comment.
Please use FFA_PART_PROP_DIRECT_REQ_RECV | FFA_PART_PROP_DIRECT_REQ_SEND | FFA_PART_PROP_INDIRECT_MSGS instead of 0x7.
balint-dobszay-arm
force-pushed
the
vm-msg
branch
from
ac591fa
to
2cd448b
Compare
gyuri-szing
reviewed
Jul 31, 2024
| @@ -120,7 +120,9 @@ TEE_Result sp_partition_info_get(uint32_t ffa_vers, void *buf, size_t buf_size, | |||
| { | |||
| TEE_Result res = TEE_SUCCESS; | |||
| uint32_t part_props = FFA_PART_PROP_DIRECT_REQ_RECV | | |||
| FFA_PART_PROP_DIRECT_REQ_SEND; | |||
| FFA_PART_PROP_DIRECT_REQ_SEND | | |||
There was a problem hiding this comment.
Aren't these properties owned by the SP? Shouldn't these be read from the manifest?
balint-dobszay-arm
force-pushed
the
vm-msg
branch
from
2cd448b
to
88959d3
Compare
|
I think the qemu failure is unrelated to this PR. The checkpatch failure is just for a long error message. |
That is #6952 again, indeed.
...that we want to keep on a single line, yes. Thanks! |
balint-dobszay-arm
force-pushed
the
vm-msg
branch
from
88959d3
to
ef0ee6b
Compare
|
Thanks, tag applied |
Please apply the tag to the first commit too 😉 |
So far the properties of S-EL0 SPs have been hardcoded when queried by FFA_PARTITION_INFO_GET. This was supposed to be a temporary workaround, so replace this with reading the properties from the SP's manifest which is the proper solution. Acked-by: Jens Wiklander <[email protected]> Signed-off-by: Balint Dobszay <[email protected]>
The VM availability messages sent by the hypervisor to an SP should be forwarded to the SP, if the SP has subscribed for these based on the SP manifest. Acked-by: Jens Wiklander <[email protected]> Signed-off-by: Balint Dobszay <[email protected]>
balint-dobszay-arm
force-pushed
the
vm-msg
branch
from
ef0ee6b
to
a51894f
Compare
Ooops, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.