Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe tee.bin and tee-raw.bin in the porting guidelines #251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

calebccff
Copy link

For someone just trying to launch OP-TEE and print "Hello World!",
tee.bin seems like the obvious binary to use. However it contains a
non-executable header(?!) which can cause some lost days of debugging.

Add a mention that tee-raw.bin should be used as it can just be jumped
to.

cc @jenswi-linaro

These don't appear to be needed, and pm_stub no longer exists. Remove
them so this code will at least compile again.

Signed-off-by: Caleb Connolly <[email protected]>
For someone just trying to launch OP-TEE and print "Hello World!",
tee.bin seems like the obvious binary to use. However it contains a
non-executable header(?!) which can cause some lost days of debugging.

Add a mention that tee-raw.bin should be used as it can just be jumped
to.

Signed-off-by: Caleb Connolly <[email protected]>
@jenswi-linaro
Copy link
Contributor

For the commit "architecutre: porting: drop defunct thread handles from main.c":
s/architecutre/architecture/
With that fixed, please apply:
Reviewed-by: Jens Wiklander <[email protected]>

I appreciate the initiative with "architecutre: porting: describe tee.bin and tee-raw.bin", but we should describe all the produced binaries. I can attempt that, so please drop the commit.

@etienne-lms
Copy link
Contributor

For commit "architecutre: porting: drop defunct thread handles from main.c":
Acked-by: Etienne Carriere <[email protected]> with @jenswi-linaro comment addressed + prefer replace pm_stub with explicit pm_stub.h in commit message. Note that generic_boot.h and other resources define in the code example neither exists since a few release tags. Maybe simpler to state in the commit message that the change is intended to "Update proting description since many resources are deprecated since at least release tag 3.10.0".

@jbech-linaro
Copy link
Contributor

@calebccff @jenswi-linaro , will we abandon this, since we have merged the other PR from Jens that explains binaries better?

@jenswi-linaro
Copy link
Contributor

We want the first commit, "architecutre: porting: drop defunct thread handles from main.c".

@jbech-linaro
Copy link
Contributor

Alright, makes sense, @calebccff , can you remove the second commit, rebase, add Jens and Etiennes tags and force push to your branch? When done, I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants