Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDCSRM-520 Productionise action rule status #342

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

kacperpONS
Copy link
Contributor

@kacperpONS kacperpONS commented Jun 17, 2024

Motivation and Context

We need to set and display the new action rule status field on action rules.

What has changed

  • Add action rule status to action rule API
  • Display the action rule status in the action rule details instead of has_triggered

How to test?

Build the linked DDL branch, then the linked case processor branch, then this branch.
Run docker dev
Run some action rules and watch the status change in the UI

Links

https://jira.ons.gov.uk/browse/SDCSRM-520

@kacperpONS kacperpONS added the feature Adds or alters functionality label Jun 20, 2024
pom.xml Outdated Show resolved Hide resolved
@AdamHawtin AdamHawtin changed the title Productionise action rule status SDCSRM-520 Productionise action rule status Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.90%. Comparing base (1be32ab) to head (043c2b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #342      +/-   ##
============================================
+ Coverage     49.85%   49.90%   +0.05%     
- Complexity      366      367       +1     
============================================
  Files            98       98              
  Lines          2710     2713       +3     
  Branches        130      130              
============================================
+ Hits           1351     1354       +3     
  Misses         1291     1291              
  Partials         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamHawtin AdamHawtin merged commit d305764 into main Jul 3, 2024
4 checks passed
@AdamHawtin AdamHawtin deleted the SDCSRM-520-productionise-action-rule-status branch July 3, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds or alters functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants