Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-1296 Update Flask cors in secure-message #430

Merged
merged 2 commits into from
Sep 25, 2024
Merged

RAS-1296 Update Flask cors in secure-message #430

merged 2 commits into from
Sep 25, 2024

Conversation

LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Sep 20, 2024

What and why?

This PR update flask CORS due to a vulnerability

edit: on update another issue has been found which there is no fix so has been ignored

How to test?

CORS is only used in the app create, so the fact the test run says it all. You can however deploy and run the app and acceptance tests if you like (I did)

Jira

@anwilkie
Copy link
Contributor

/deploy wilkia

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: wilkia

  • tag: pr-430

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@anwilkie anwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests work, app deploys and new ignore is appropriate

@LJBabbage LJBabbage merged commit d92cbe5 into main Sep 25, 2024
1 check passed
@LJBabbage LJBabbage deleted the update-cors branch September 25, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants