Have added bot signature, fixed CVE and ignored 2 CVEs #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pricem14pc
reviewed
Jun 28, 2024
Pipfile
Outdated
| @@ -24,6 +24,7 @@ numpy = "*" | |||
| google-cloud-pubsub = "*" | |||
| flask-sqlalchemy = "*" | |||
| flask = "*" | |||
| jinja2 = "*" | |||
There was a problem hiding this comment.
We may do, but did you mean to add this as an explicit dependency? It's a third party dependency of Flask-Cors, Flask-RESTful and flask-sqlalchemy. I'm never sure if we should just upgrade those and let them resolve it.
There was a problem hiding this comment.
This has been removed. I never meant to have included it. I was just testing a theory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Signed pr-bot commits and have ignored 2 vulnerabilities where there are currently no fixes for.