Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-1289 Update the way claims is determined in the party service: #428

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Sep 13, 2024

What and why?

This PR adds in the survey value which should be being passed to party. All the docs say it is doing it, but unfortunately it currently doesn't and means a business could send messages without being enrolled on that survey

How to test?

Test in conjunction with ONSdigital/ras-party#435, trying sending a new email via the survey help route, the account help route and replying to an existing thread. Reply and create a new message in ROPs as well

Jira

@mfcrocker
Copy link
Collaborator

/deploy crockers

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: crockers

  • tag: pr-428

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@anwilkie
Copy link
Contributor

/deploy wilkia

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: wilkia

  • tag: pr-428

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@LJBabbage LJBabbage merged commit ec601ee into main Sep 20, 2024
1 check passed
@LJBabbage LJBabbage deleted the update-claims-to-pass-survey-id branch September 20, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants