RAS-1289 Update the way claims is determined in the party service #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJBabbage
commented
Sep 13, 2024
|
/deploy crockers |
|
Deploying to dev cluster with following parameters:
|
|
/deploy wilkia |
|
Deploying to dev cluster with following parameters:
|
mfcrocker
approved these changes
Sep 18, 2024
anwilkie
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
This PR updates how claims are processed and introduces survey_id in the check. This is part of a larger piece of reducing the amount of 139 crashes, at present get_respondent_by_id is doing more that what it should and by calling to_respondent_with_associations_dict() causing considerable overhead leading to timeouts. I can't remove get_respondent_by_id or the dict it is generating, but I can move the functionality to a cleaner function which just returns the repondent and then make enrolment checks cleaner and far more efficient
How to test?
Test in conjunction with ONSdigital/ras-secure-message#428, trying sending a new email via the survey help route, the account help route and replying to an existing thread. Reply and create a new message in ROPs as well
Jira