RAS-1265 Correct order of claim call in secure messaging (#427)

* RAS-1265 Correct order of claim call in secure messaging
ONSdigital · Aug 16, 2024 · 05a54d7 · 05a54d7
1 parent ddcea57
commit 05a54d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/_infra/helm/secure-message/Chart.yaml b/_infra/helm/secure-message/Chart.yaml
@@ -14,8 +14,8 @@ type: application
 
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 2.1.74
+version: 2.1.75
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
-appVersion: 2.1.74
+appVersion: 2.1.75
diff --git a/secure_message/resources/messages.py b/secure_message/resources/messages.py
@@ -41,7 +41,7 @@ def post(self):
             False if "category" in post_data and post_data["category"] in ["TECHNICAL", "MISC"] else True
         )
         # Validate claim
-        if not self._has_valid_claim(g.user, message) and has_survey_category:
+        if has_survey_category and not self._has_valid_claim(g.user, message):
             logger.info("Message send failed", error="Invalid claim")
             return make_response(jsonify("Invalid claim"), 403)