Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ignore #1001

Merged
merged 7 commits into from
Oct 25, 2024
Merged

remove ignore #1001

merged 7 commits into from
Oct 25, 2024

Conversation

anwilkie
Copy link
Contributor

@anwilkie anwilkie commented Oct 17, 2024

What and why?

This PR removes an unneeded ignore from the makefile.

How to test?

Deploy and run tests.

Do a pipenv install, pipenv graph, and check that the following depenencies have updated:
certifi = ">=2024.07.04"
requests = ">=2.32.0"
urllib3 = ">=2.2.2"

Jira

Card

@anwilkie
Copy link
Contributor Author

/deploy wilkia

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: wilkia

  • tag: pr-1001

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@arroyoAle arroyoAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine - but there are a few dependabot alerts open that might be able to be progressed

Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and resolves vulnerabilities

@anwilkie anwilkie merged commit 42f7eae into main Oct 25, 2024
3 checks passed
@anwilkie anwilkie deleted the ras-1315-python-ignores-review branch October 25, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants