Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant attribute #517

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

remove redundant attribute #517

wants to merge 1 commit into from

Conversation

NoelleDL
Copy link
Contributor

@NoelleDL NoelleDL commented Nov 25, 2020 •
edited
Loading

What

role="main" attribute is unnecessary since semantic HTML <main> element is used.

How to review

Inspect any page on develop and within the main element see there is role="main". Pull this branch, inspect page and see there is no role="main" within the main element.

Who can review

Anyone but me.

rav-pradhan
rav-pradhan reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@rav-pradhan rav-pradhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think IE11 supports the main element, which is why we have role="main" included as the fallback. Just want to check we do still want to remove it on that basis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rav-pradhan rav-pradhan rav-pradhan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelleDL @rav-pradhan