[feat] 약속 나가기, 약속 삭제하기 API 구현 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdwns414
approved these changes
Aug 20, 2024
| @@ -25,7 +25,7 @@ public void checkUserInMeeting(JoinPoint joinPoint, IsParticipant checkUserInPro | |||
| Long userId = (Long) SecurityContextHolder.getContext().getAuthentication().getPrincipal(); | |||
|
|
|||
| if (!participantRetriever.existsByPromiseIdAndUserId(promiseId, userId)) { | |||
| throw new MemberException(MemberErrorCode.NOT_JOINED_MEMBER); | |||
| throw new ParticipantException(ParticipantErrorCode.NOT_JOINED_PROMISE); | |||
There was a problem hiding this comment.
오... 모르고 있던 실수가 있었군요. 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
약속한 속한 모든 참가자들을 삭제할 때
deleteAll과는 다르게 단일 쿼리를 보내 성능이 향상된다는deleteAllInBatch를 사용해보았습니다..! 그러나deleteAllInBatch가 영속성 컨텍스트 관련 처리는 생략한다고 한다고 해서 적절한 선택을 한건지 고민이 됩니다.