Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Multipart 관련 오류 수정 #78

Merged
merged 3 commits into from
Jul 19, 2024
Merged

[fix] Multipart 관련 오류 수정 #78

merged 3 commits into from
Jul 19, 2024

Conversation

chaewonni
Copy link
Member

Related issue 🛠

Work Description ✏️

  • 디스코드 로깅 설정 후 S3 이미지 업로드가 안되는 오류 수정
  • S3이미지 수정(재업로드) 및 삭제시 S3에서 이미지가 삭제되지 않는 오류 수정
  • 자세한 내용은 작업실 로깅 후 s3 이미지 업로드가 안돼요… 에 있습니다...

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

  • develop에서 commit하고 다른 브랜치에서 push하는 실험을 하면서 먼가 어려움이 생겼습니다..... 흙흑.,.,,,.,,
  • 그리고 ServletWrappingFilter를 수정한거라.. 이거 머지되고도 로깅 잘 되는지 확인 한 번 해봐야할 것 같습니다..!

@chaewonni chaewonni requested a review from tkdwns414 July 19, 2024 00:44
@chaewonni chaewonni self-assigned this Jul 19, 2024
tkdwns414
tkdwns414 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@tkdwns414 tkdwns414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말정말 잘하셨습니다. 자고 일어났는데 노션에 트슈 적어놓은 것 보고 깜짝 놀랐어요.
LGTMLGTMLGTM~

@chaewonni chaewonni merged commit a196750 into develop Jul 19, 2024
1 check passed
@chaewonni chaewonni deleted the fix/77 branch July 19, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkdwns414 tkdwns414 tkdwns414 approved these changes

Assignees

@chaewonni chaewonni

Labels
fix 🐩 채원 🐩
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Multipart 관련 오류 수정
2 participants
@chaewonni @tkdwns414