Master #44
Open
Master #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates symfony packages to v5
updates dependency
|
I'm sorry, I cannot merge this. What problem are you trying to solve? This update would break backwards compatibility with many plugins from the October ecosystem. If we need support for newer symfony packages, we would have to be inclusive (from v3 to v5) and see if it works with them all. As an example: October requires |
|
Sorry for the commotion. Had a mix-up with my "new" GIT client.
Wasn't supposed to happen like that. Sry!
… Am 05.05.2020 um 08:34 schrieb Tobias Kündig ***@***.***>:
I'm sorry, I cannot merge this. What problem are you trying to solve?
This update would break backwards compatibility with many plugins from the October ecosystem.
If we need support for newer symfony packages, we would have to be inclusive (from v3 to v5) and see if it works with them all.
As an example:
October requires laravel/framework v5.5 which requires symfony/console v3.3 <https://github.com/laravel/framework/blob/5.5/composer.json#L31>. This fundamental dependecy is broken by this PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEQKXEJME7T5J67EEBVS4TRP6XNXANCNFSM4MZDJQKA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.