-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add napoleon ext #103
add napoleon ext #103
Conversation
@@ -33,6 +33,7 @@ | |||
extensions = [ | |||
'sphinx.ext.autodoc', | |||
'sphinx.ext.viewcode', | |||
'sphinx.ext.napoleon', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsetiawan I forgot that napoleon
, the extension for the numpy/scipy and google style docstrings, is builtin and we still need to enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! :)
docs/source/modules.rst
Outdated
:mod:`Read Services` | ||
---------------------- | ||
|
||
.. automodule:: odm2api.ODM2.services.readService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't fixed all the docstring for this module yet. It's gonna be a mess except for one function getAffiliations
. But I guess for now that's fine. The current docstrings still rendered, at lease now I can see it without going to the actual module python file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to merge this. I only sent the PR to show you with code that what was wrong was not your docstring 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe remove this change and keep the other one to conf.py
so I can merge? Thanks 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ocefpaf. I'll merge once it's green!
Closes #102