Change default to False for should_exit_on_error

OCHA-DAP · Jan 14, 2025 · 17bf070 · 17bf070
1 parent 96bde80
commit 17bf070
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/hdx/utilities/error_handler.py b/src/hdx/utilities/error_handler.py
@@ -18,13 +18,13 @@ class ErrorHandler:
     sorted.
 
     Args:
-        should_exit_on_error (bool): Whether to exit with a 1 code if there are errors. Default is True.
+        should_exit_on_error (bool): Whether to exit with a 1 code if there are errors. Default is False.
 
     """
 
     def __init__(
         self,
-        should_exit_on_error: bool = True,
+        should_exit_on_error: bool = False,
     ):
         self.should_exit_on_error = should_exit_on_error
         self.shared_errors = {

diff --git a/tests/hdx/utilities/test_error_handler.py b/tests/hdx/utilities/test_error_handler.py
@@ -17,7 +17,7 @@ def test_error_handler(self, caplog):
             assert len(errors.shared_errors["error"]) == 0
         with pytest.raises(SystemExit):
             with caplog.at_level(logging.ERROR):
-                with ErrorHandler() as errors:
+                with ErrorHandler(should_exit_on_error=True) as errors:
                     errors.add("this is a error!")
                     errors.add("this is a warning!", "warning 1", "warning")
                     errors.add_missing_value(