Fix set use live default #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, the tests have failed. They passed on my branch: https://github.com/andy-isoc/hdx-python-country/actions/runs/11911364328 (and they passed for me locally) |
|
I will merge this and fix this issue with running tests in Hatch. Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit out of my depth with the subtleties of Python here but it looks like using the cls variable
_use_liveas a method param default is not reading the cls value set elsewhere and is always evaluating to the hard-coded defaultTrue. Setting it toNoneand then checking when it's read and applying the default there seems to work. Though happy to change it if there's a more Pythonic approach to fixing this.Note, this fixes #62