Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time period, format and retry fix #58

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Time period, format and retry fix #58

merged 7 commits into from
Dec 13, 2023

Conversation

mcarans
Copy link
Collaborator

@mcarans mcarans commented Dec 13, 2023

Change reference_period to time_period
Deprecate reference_period methods
Change file_type to format
Deprecate file_type methods
Fix retry logic

Copy link

Test Results

132 tests  ±0   132 ✔️ ±0   27s ⏱️ -15s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit c253cbb. ± Comparison against base commit 1bf8830.

@coveralls
Copy link

Coverage Status

coverage: 97.659% (-1.0%) from 98.656%
when pulling c253cbb on time_period
into 1bf8830 on main.

@mcarans
Copy link
Collaborator Author

mcarans commented Dec 13, 2023

Coverage decline is due to currently unused RemoteHDX with special code for 429 rate limiting which will either be activated if the HDX server can return Retry-After or deleted.

@mcarans mcarans merged commit eac027e into main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants