Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDXDSYS-1190 HAPI SQLAlchemy Schema - fix datetimes #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HDXDSYS-1190 HAPI SQLAlchemy Schema - fix datetimes #70

wants to merge 1 commit into from
+8 −16

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Oct 17, 2024 •
edited
Loading

These changes simply bring idps and returnees in line with other tables

@github-actions GitHub Actions
Copy link

Test Results

115 tests  ±0   115 ✅ ±0   55s ⏱️ +26s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e9b46fc. ± Comparison against base commit 339377c.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11379227902

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.447%
Totals Coverage Status
Change from base Build 11355724549: 0.0%
Covered Lines: 1104
Relevant Lines: 1323
💛 - Coveralls

IanHopkinson
IanHopkinson approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@IanHopkinson IanHopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, should have no downstream impact, it is just a change in how the type annotations are done in the IDPS and returnees tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanHopkinson IanHopkinson IanHopkinson approved these changes

@b-j-mills b-j-mills b-j-mills approved these changes

@turnerm turnerm Awaiting requested review from turnerm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcarans @coveralls @IanHopkinson @b-j-mills