Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-1085 Humanitarian needs table - replace gender, age, disability and population group columns with freeform category column #67

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Oct 1, 2024

Javier requested we replace gender, age, disability and population group columns with the freeform category column because country offices do not have common standards so we can not reliably map that column to fixed gender, age, disability and population group values.

Copy link

github-actions bot commented Oct 1, 2024

Test Results

115 tests   - 2   115 ✅  - 2   27s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6bb9936. ± Comparison against base commit 586c8c6.

This pull request removes 2 tests.
tests.test_humanitarian_needs ‑ test_maxage
tests.test_humanitarian_needs ‑ test_minage

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11355263494

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 83.447%

Totals Coverage Status
Change from base Build 11353433740: -0.2%
Covered Lines: 1104
Relevant Lines: 1323

💛 - Coveralls

Copy link
Member

@turnerm turnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a depressing change :C

src/hapi_schema/db_humanitarian_needs.py Show resolved Hide resolved
@mcarans mcarans changed the title Humanitarian needs table - replace gender, age, disability and population group columns with freeform category column HDXDSYS-1085 Humanitarian needs table - replace gender, age, disability and population group columns with freeform category column Oct 2, 2024
@IanHopkinson
Copy link
Contributor

Is this OK to merge and publish as a version so that we can implement in HAPI/HWA? cc @turnerm

@turnerm
Copy link
Member

turnerm commented Oct 14, 2024

I'll leave it to @mcarans as we still need to merge the pipeline branch

@mcarans mcarans merged commit c29a042 into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants