Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add national risk #15

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add national risk #15

merged 3 commits into from
Jan 17, 2024

Conversation

b-j-mills
Copy link
Collaborator

@b-j-mills b-j-mills commented Jan 15, 2024 •
edited
Loading

Please let me know if I missed anything! My only concern is the naming - should I change it to just "risk"?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

Test Results

19 tests  +1   19 ✅ +1   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b79ab8e. ± Comparison against base commit a1c22d9.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Jan 15, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 7547208557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.854%
Totals Coverage Status
Change from base Build 7296198953: 0.1%
Covered Lines: 345
Relevant Lines: 349
💛 - Coveralls

mcarans
mcarans approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@mcarans mcarans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@davidmegginson
Copy link
Member

I'd stick with national risk, because we might add subnational or other types of risk later.

davidmegginson
davidmegginson requested changes Jan 16, 2024
View reviewed changes
src/hapi_schema/db_national_risk.py Outdated Show resolved Hide resolved
src/hapi_schema/db_national_risk.py Outdated Show resolved Hide resolved
src/hapi_schema/db_national_risk.py Show resolved Hide resolved
src/hapi_schema/db_national_risk.py Show resolved Hide resolved
@b-j-mills
Copy link
Collaborator Author

@davidmegginson if all looks good I'll go ahead and merge!

davidmegginson
davidmegginson approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@davidmegginson davidmegginson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@b-j-mills b-j-mills merged commit 3d286a7 into main Jan 17, 2024
3 checks passed
@turnerm turnerm deleted the HAPI-322 branch October 1, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmegginson davidmegginson davidmegginson approved these changes

@mcarans mcarans mcarans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-j-mills @coveralls @davidmegginson @mcarans