[16.0][MIG] sale_pricelist_global_rule #3533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quantities across sales order lines - by product template - by product category
…onstraint conflicts The `product_variant_default_code` module adds a unique constraint, which causes test failures when installed alongside `sale_pricelist_global_rule`. This fix adjusts the tests in to avoid conflicts with this unique constraint, ensuring compatibility when both modules are installed.
If not, we get:
```
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 658, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 301, in _handle_exception
raise exception.with_traceback(None) from new_cause
psycopg2.errors.DatatypeMismatch: ARRAY types integer and boolean cannot be matched
LINE 9: ...L OR item.global_product_tmpl_id = any(ARRAY[false,...
```
A little refactor for better code in the method is also done.
TT51677
…putes complementary to commit 637c766
|
/ocabot migration sale_pricelist_global_rule |
LuciaMarchalFactorLibre
force-pushed
the
16.0-mig-sale_pricelist_global_rule
branch
from
d0c9dc5 to
423ca3c
Compare
LuciaMarchalFactorLibre
force-pushed
the
16.0-mig-sale_pricelist_global_rule
branch
from
423ca3c to
5874049
Compare
mmequignon
requested changes
Jan 17, 2025
Comment on lines
+24
to
+48
| self.env.cr.execute( | ||
| """ | ||
| SELECT | ||
| item.id | ||
| FROM | ||
| product_pricelist_item AS item | ||
| LEFT JOIN product_category AS categ ON item.categ_id = categ.id | ||
| WHERE | ||
| (item.product_tmpl_id IS NULL OR item.product_tmpl_id = any(%s)) | ||
| AND (item.product_id IS NULL OR item.product_id = any(%s)) | ||
| AND (item.categ_id IS NULL OR item.categ_id = any(%s)) | ||
| AND (item.pricelist_id = %s) | ||
| AND (item.date_start IS NULL OR item.date_start<=%s) | ||
| AND (item.date_end IS NULL OR item.date_end>=%s) | ||
| AND (item.active = TRUE) | ||
| ORDER BY | ||
| item.applied_on, item.min_quantity desc, categ.complete_name desc, item.id desc | ||
| """, | ||
| (prod_tmpl_ids, prod_ids, categ_ids, self.id, date, date), | ||
| ) | ||
| # NOTE: if you change `order by` on that query, make sure it matches | ||
| # _order from model to avoid inconstencies and undeterministic issues. | ||
|
|
||
| item_ids = [x[0] for x in self.env.cr.fetchall()] | ||
| items = self.env["product.pricelist.item"].browse(item_ids) |
There was a problem hiding this comment.
Are you re implementing the whole thing, and ignoring the recursion, or am I missing something?
|
Hi, I started the migration to 17 and did a significant refactor to reuse Odoo functions. These functions have been available since V16. I think it’s a good idea to take into account the changes from V17, as they may also be applicable here. Please check this PR: #3526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of the sale_pricelist_global_rule module from version 15.0 to 16.0
FL-556-4652