[16.0] [IMP] Make packaging required on orders for configured products.

sale_order_product_recommendation_packaging_default/tests/test_recommendation.py

@@ -2,6 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl-3.0)
 from freezegun import freeze_time
 
+from odoo.exceptions import UserError
 from odoo.fields import Command
 from odoo.tests import tagged
 from odoo.tests.common import Form
@@ -234,3 +235,16 @@
                 },
             ],
         )
+
+    def test_product_require_packaging(self):
+        """Test that products with the required packaging cannot be sold
+        separated without packaging."""
+        so_f = Form(self.env["sale.order"])
+        so_f.partner_id = self.partner
+        self.prod_1.require_packaging = True
+        with so_f.order_line.new() as line_f:
+            line_f.product_id = self.prod_1
+            self.assertTrue(line_f.require_packaging)
+            with self.assertRaises(UserError):
+                line_f.product_uom_qty = 1
+                so_f.save()

sale_order_product_recommendation_packaging_default/wizards/sale_order_recommendation.py

@@ -2,7 +2,8 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl-3.0)
 
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class SaleOrderRecommendationLine(models.TransientModel):
@@ -26,6 +27,7 @@
         digits="Product Unit of Measure",
         help="Quantity of packagings to sell.",
     )
+    require_packaging = fields.Boolean(compute="_compute_require_packaging")
 
     @api.depends("product_id", "units_included", "sale_uom_id")
     def _compute_product_packaging(self):
@@ -109,3 +111,22 @@
             # Nothing to create
             return result
         return self._prepare_packaging_line_vals(result)
+
+    @api.depends("product_id")
+    def _compute_require_packaging(self):
+        for line in self:
+            line.require_packaging = line.product_id.require_packaging
+
+    @api.depends("product_id", "product_uom_qty", "product_uom")
+    def _warning_product_packaging_required(self):
+        """Notify the user when a packaging is required."""
+        result = {}
+        for line in self:
+            if line.require_packaging and not line.product_packaging_id:
+                raise UserError(
+                    _(
+                        "The product %s requires a packaging to be sold"
+                        % line.product_id.name
+                    )
+                )
+        return result

sale_order_product_recommendation_packaging_default/wizards/sale_order_recommendation_view.xml

@@ -10,6 +10,14 @@
             ref="sale_order_product_recommendation.sale_order_recommendation_view_form"
         />
         <field name="arch" type="xml">
+
+            <xpath
+                expr="//field[@name='line_ids']/form//field[@name='units_included']"
+                position="before"
+            >
+                <field name="require_packaging" invisible="1" />
+            </xpath>
+
             <xpath
                 expr="//field[@name='line_ids']/tree/field[@name='units_included']"
                 position="before"
@@ -36,12 +44,13 @@
                     name="product_packaging_id"
                     groups="product.group_stock_packaging"
                     context="{'default_product_id': product_id}"
+                    attrs="{'required': [('require_packaging', '=', True)]}"
                 />
                 <field
                     name="product_packaging_qty"
                     groups="product.group_stock_packaging"
                     widget="numeric_step"
-                    attrs="{'readonly': [('product_packaging_id', '=', False)]}"
+                    attrs="{'readonly': ['|', ('product_packaging_id', '=', False), ('require_packaging', '=', True)]}"
                 />
             </xpath>
         </field>

sale_packaging_default/README.rst

@@ -71,6 +71,11 @@ To configure this module, you need to:
 1. Go to *Sales > Configuration > Settings*.
 2. Under *Product Catalog*, enable *Product Packagings*.
 
+To configure products for mandatory packaging:
+
+1. Go to \*Inventory > Product and select a product.
+2. Under the ‘Inventory’ tab check the box for ‘Require Packaging'.
+
 Usage
 =====
 

sale_packaging_default/__manifest__.py

@@ -15,6 +15,7 @@
     "installable": True,
     "depends": ["sale"],
     "data": [
+        "views/product_template_view.xml",
         "views/sale_order_view.xml",
     ],
 }

sale_packaging_default/models/__init__.py

@@ -1,2 +1,3 @@
 from . import product_packaging
+from . import product_template
 from . import sale_order_line

sale_packaging_default/models/product_template.py

@@ -0,0 +1,9 @@
+# Copyright 2024 Moduon Team S.L.
+# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl-3.0)
+from odoo import fields, models
+
+
+class ProductTemplate(models.Model):
+    _inherit = "product.template"
+
+    require_packaging = fields.Boolean(default=False)

sale_packaging_default/models/sale_order_line.py

@@ -2,12 +2,15 @@
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl-3.0)
 from contextlib import suppress
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class SaleOrderLine(models.Model):
     _inherit = "sale.order.line"
 
+    require_packaging = fields.Boolean(compute="_compute_require_packaging")
+
     def onchange(self, values, field_name, field_onchange):
         """Record which field was being changed."""
         if isinstance(field_name, list):
@@ -43,6 +46,23 @@
                     and line.product_uom_qty % line.product_packaging_id.qty
                 ):
                     line.product_packaging_id = False
+                    res = line._warning_product_packaging_required()
+                    if res:
+                        return res
+        return result
+
+    @api.depends("product_id", "product_uom_qty", "product_uom")
+    def _warning_product_packaging_required(self):
+        """Notify the user when a packaging is required."""
+        result = {}
+        for line in self:
+            if line.require_packaging and not line.product_packaging_id:
+                raise UserError(
+                    _(
+                        "The product %s requires a packaging to be sold"
+                        % line.product_id.name
+                    )
+                )
         return result
 
     @api.model
@@ -84,3 +104,8 @@
         _self = self.with_context(keep_product_packaging=True)
         result = super(SaleOrderLine, _self)._compute_product_uom_qty()
         return result
+
+    @api.depends("product_id")
+    def _compute_require_packaging(self):
+        for line in self:
+            line.require_packaging = line.product_id.require_packaging

sale_packaging_default/readme/CONFIGURE.md

@@ -2,3 +2,9 @@ To configure this module, you need to:
 
 1.  Go to *Sales \> Configuration \> Settings*.
 2.  Under *Product Catalog*, enable *Product Packagings*.
+
+
+To configure products for mandatory packaging:
+
+1. Go to *Inventory \> Product and select a product.
+2. Under the ‘Inventory’ tab check the box for ‘Require Packaging'.

sale_packaging_default/static/description/index.html

@@ -419,6 +419,11 @@ <h1><a class="toc-backref" href="#toc-entry-2">Configuration</a></h1>
 <li>Go to <em>Sales &gt; Configuration &gt; Settings</em>.</li>
 <li>Under <em>Product Catalog</em>, enable <em>Product Packagings</em>.</li>
 </ol>
+<p>To configure products for mandatory packaging:</p>
+<ol class="arabic simple">
+<li>Go to *Inventory &gt; Product and select a product.</li>
+<li>Under the ‘Inventory’ tab check the box for ‘Require Packaging’.</li>
+</ol>
 </div>
 <div class="section" id="usage">
 <h1><a class="toc-backref" href="#toc-entry-3">Usage</a></h1>

sale_packaging_default/tests/test_sale_packaging_default.py

@@ -1,6 +1,7 @@
 # Copyright 2023 Moduon Team S.L.
 # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl-3.0)
 from odoo import fields
+from odoo.exceptions import UserError
 from odoo.tests.common import Form
 
 from odoo.addons.product.tests.common import ProductCommon
@@ -126,3 +127,16 @@
             self.assertEqual(line_f.product_packaging_id, self.p2_three_pack)
             self.assertEqual(line_f.product_packaging_qty, 10)
             self.assertEqual(line_f.product_uom_qty, 30)
+
+    def test_product_require_packaging(self):
+        """Test that products with the required packaging cannot be sold
+        separated without packaging."""
+        so_f = Form(self.env["sale.order"])
+        so_f.partner_id = self.partner
+        self.product2.require_packaging = True
+        with so_f.order_line.new() as line_f:
+            line_f.product_id = self.product2
+            self.assertTrue(line_f.require_packaging)
+            with self.assertRaises(UserError):
+                line_f.product_uom_qty = 1
+                so_f.save()

sale_packaging_default/views/product_template_view.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- Copyright 2024 Moduon Team S.L. <[email protected]>
+     License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl). -->
+<data>
+
+    <record id="product_template_form_view_inherit" model="ir.ui.view">
+        <field name="name">Simplify packaging fields</field>
+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="product.product_template_form_view" />
+        <field name="arch" type="xml">
+            <xpath expr="//page[@name='inventory']" position="inside">
+                <group string="Packaging Division">
+                    <field
+                        name="require_packaging"
+                        placeholder="Indicates if the product can be sold individually or if it requires keeping the original packaging."
+                    />
+                </group>
+            </xpath>
+        </field>
+    </record>
+
+</data>

sale_packaging_default/views/sale_order_view.xml

@@ -36,6 +36,33 @@
                     position="move"
                 />
             </xpath>
+
+            <xpath
+                expr="//field[@name='order_line']/tree/field[@name='product_packaging_id']"
+                position="before"
+            >
+                <field name="require_packaging" invisible="1" />
+            </xpath>
+
+            <!-- Make packaging mandatory when the product is not allow to divide the packaging -->
+            <xpath
+                expr="//field[@name='order_line']/tree/field[@name='product_packaging_id']"
+                position="attributes"
+            >
+                <attribute
+                    name="attrs"
+                >{'required': [('require_packaging', '=', True)]}</attribute>
+            </xpath>
+
+            <!-- Make packaging qty readonly when the product is not allow to divide the packaging -->
+            <xpath
+                expr="//field[@name='order_line']/tree/field[@name='product_packaging_qty']"
+                position="attributes"
+            >
+                <attribute
+                    name="attrs"
+                >{'readonly': [('require_packaging', '=', True)]}</attribute>
+            </xpath>
         </field>
     </record>
 </data>