Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] pos_tare: Migration to 14.0 #980

Closed
wants to merge 28 commits into from

Conversation

baimont
Copy link

@baimont baimont commented Apr 21, 2023

legalsylvain and others added 27 commits April 7, 2023 13:42
[ADD] barcode nomenclature for tare
[ADD] tare field on pos.order.line model
[ADD] Tare button in PoS numpad
[IMP] handle correctly different UoM
[IMP] add warning at checkout if qty <=0
[IMP] display gross and tare weight for each line

Co-authored-by: François Kawala <[email protected]>
Co-authored-by: Sylvain LE GAL <[email protected]>
Currently translated at 100.0% (46 of 46 strings)

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/
Currently translated at 100.0% (55 of 55 strings)

Translation: pos-12.0/pos-12.0-pos_tare
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_tare/it/
@legalsylvain
Copy link
Contributor

/ocabot migration pos_tare

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Apr 21, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 21, 2023
16 tasks
@sanrav
Copy link

sanrav commented Apr 24, 2023

See my issue created for the V12 => #984

In V14, I have the same issue with the tare barcode reading in the scaling screen but the difference with the V12 is that the product is added to the order :

image

@baimont baimont changed the title [14.0][MIG] pos_tare: Migration to 14.0 [DRAFT][14.0][MIG] pos_tare: Migration to 14.0 May 4, 2023
@baimont baimont changed the title [DRAFT][14.0][MIG] pos_tare: Migration to 14.0 [14.0][MIG] pos_tare: Migration to 14.0 May 4, 2023
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 17, 2023
@github-actions github-actions bot closed this Oct 22, 2023
@legalsylvain legalsylvain reopened this Nov 26, 2023
}
}

async _getAddProductOptions(product) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewriting all this function is not a good option.
I think you can return weight + tare in the payload of the "ScaleScreen", and then overload _getAddProductOptions just to split the quantity field into the two weight and tare. What do you thing ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @legalsylvain and thanks for your comment.
As I remember I really tried not to do that but I didn't have the choice. I cannot tell you why exactly as I currently work on other projects and haven't touch this for months. If you are sure of you, you can maybe propose some changes and I'll gladly take a look (and test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants