Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] partner_identification: Add chatter in res.partner.id_number form pop-up #1932

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

vehi-invitu
Copy link

Description:
Integrate the Odoo Chatter to enable uploading attachment files through the res.partner pop-up form for ID Numbers.

cc @cvinh

@cvinh
Copy link

cvinh commented Dec 14, 2024

Please fix pre-commit

@vehi-invitu vehi-invitu force-pushed the 17.0-imp_res_partner_form_add_attachment branch 2 times, most recently from a04dd74 to ed6f70e Compare December 18, 2024 18:41
@vehi-invitu vehi-invitu changed the title [IMP] partner_identification: Add chatter in res.partner.id_number form pop-up [17.0][IMP] partner_identification: Add chatter in res.partner.id_number form pop-up Dec 18, 2024
@vehi-invitu vehi-invitu force-pushed the 17.0-imp_res_partner_form_add_attachment branch from 4921c36 to 8dd5079 Compare December 18, 2024 18:52
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cvinh
Copy link

cvinh commented Jan 7, 2025

There is an issue when we add a identification as the chatter is not usable until the identification is saved... it means that we can't add an attachment in the popup during the creation

The workaround is to save the identification and open it again... then the chatter is usable...
It's not very convenient, @rousseldenis WDYT ?

@rousseldenis
Copy link
Contributor

There is an issue when we add a identification as the chatter is not usable until the identification is saved... it means that we can't add an attachment in the popup during the creation

That's the standard behavior. Record is not saved yet.

@cvinh
Copy link

cvinh commented Jan 8, 2025

There is an issue when we add a identification as the chatter is not usable until the identification is saved... it means that we can't add an attachment in the popup during the creation

That's the standard behavior. Record is not saved yet.

Ok then... let's merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants