Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] re-enable _make_default_branch #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjscarafia
Copy link

Now it's working properly

Now it's working properly
@sbidoul
Copy link
Member

sbidoul commented Oct 21, 2021

We don't use these scripts anymore. This should be added to https://github.com/OCA/maintainer-tools/blob/master/tools/create_branch.py

@pedrobaeza
Copy link
Member

There are still people using them, so it's worth to re-add it, but indeed the new one should be covered as well.

@sbidoul
Copy link
Member

sbidoul commented Feb 25, 2022

There are still people using them, so it's worth to re-add it, but indeed the new one should be covered as well.

I'm not sure I agree with that. This project is dedicated to tools for OCA maintenaners, and keeping stuff we don't use for OCA adds unnecessary maintenance burden. People are free to pickup the code in other projects.

@simahawk
Copy link
Contributor

simahawk commented Mar 5, 2023

Is this still relevant?

@pedrobaeza
Copy link
Member

pedrobaeza commented Mar 5, 2023

I think so, as we still have repos with 13.0 or 14.0 as default branch, and I have to ping you for changing them.

@simahawk
Copy link
Contributor

simahawk commented Mar 5, 2023

We don't use these scripts anymore. This should be added to https://github.com/OCA/maintainer-tools/blob/master/tools/create_branch.py

@jjscarafia can you add it there too?

Regarding the old scripts: shall we log deprecation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants