[14.0][FIX] Email formating when receive it by mail gateway, create new ticket with wrong label

[mathben]

[FIX] helpdesk_mgmt: format email when receive it from new message mail gateway

Before, email was like '"Name" [email protected]'
Now, email is like '[email protected]'
To field partner_email into model helpdesk.ticket

[mathben]

This fix #435

[mathben]

What do you think about the coverage, do I need to do more test? It's the method _extract_email I created.

[pedrobaeza]

Please check how it's done in project module and mimic it.

[mathben]

Please check how it's done in project module and mimic it.

This is the code into module project v14.0
https://github.com/odoo/odoo/blob/14.0/addons/project/models/project.py#L1312
I think it has the same problem, I will test it.
tools.email_split() this seems the way instead of using regex.

[mathben]

Please check how it's done in project module and mimic it.

It works now, I tested it.
helpdesk_mgmt it's a different case of project. It's support when partner_id not exist with partner_email and partner_name. So we can fill partner_name from name of email. I can use method tools.email_split_tuples() instead of tools.email_split()

Thanks for your reviews.

[mathben]

Codecov not pass, because of

        if not msg.get("author_id"):
            defaults["partner_name"] = partner_name

Do you want me to add a duplicate test without author?
I think I can duplicate test method test_helpdesk_ticket_message_new without "partner_ids": [newPartner.id],

Thanks

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[mathben]

I rebase with 14.0, ready to merge!

[pedrobaeza]

/ocabot merge patch

Please fw-port it to upper versions.

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-491-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at fc5e817. Thanks a lot for contributing to OCA. ❤️