[IMP]Improved code for helpdesk ticket functionality

helpdesk_mgmt/controllers/myaccount.py

@@ -259,4 +259,4 @@ def _ticket_get_order(self, order, groupby):
         field_name = groupby_mapping.get(groupby, "")
         if not field_name:
             return order
-        return "%s, %s" % (field_name, order)
+        return f"{field_name}, {order}"

helpdesk_mgmt/tests/common.py

@@ -52,8 +52,9 @@ def setUpClass(cls):
     def _create_ticket(self, team, user=False):
         return self.env["helpdesk.ticket"].create(
             {
-                "name": "Ticket %s (%s)"
-                % (team.name, user.login if user else "unassigned"),
+                "name": "Ticket {} ({})".format(
+                    team.name, user.login if user else "unassigned"
+                ),
                 "description": "Description",
                 "team_id": team.id,
                 "user_id": user.id if user else False,

helpdesk_mgmt/tests/test_helpdesk_ticket.py

@@ -135,15 +135,15 @@ def test_helpdesk_ticket_message_new(self):
         try:
             t = Ticket.message_new(msg_dict)
         except Exception as error:
-            self.fail("%s: %s" % (type(error), error))
+            self.fail(f"{type(error)}: {error}")
         self.assertEqual(t.name, title, "The ticket should have the correct title.")
 
         title = "New title"
         update_vals = {"name": title}
         try:
             t.message_update(msg_dict, update_vals)
         except Exception as error:
-            self.fail("%s: %s" % (type(error), error))
+            self.fail(f"{type(error)}: {error}")
         self.assertEqual(
             t.name, title, "The ticket should have the correct (new) title."
         )