-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FW] edi_oca: missing FW from 16.0 #118
Open
JordiMForgeFlow
wants to merge
35
commits into
OCA:17.0
Choose a base branch
from
ForgeFlow:17.0-imp-edi_oca-missing_fwp
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid warning because of duplicated Model field name while installing this module
Archived rules were not visible on the exc type form.
You can now toggle archived/unarchived directly from exc type form
Send jobs might fail due to an external service being not responsive. If the job is simply failed, a new one will be spawned and might encour in the same error again, possibly leading to an high number of duplicated jobs for the same record. Yet, when a RetryableJobError is raised, the job will be set back into pending state and will be nicely retried based on jobs configuration.
When actions are automated, is nice to see that data has been generated for an exchange on the related record.
The recommended way to execute actions on records is to call `action_exchange_*` on
JordiMForgeFlow
force-pushed
the
17.0-imp-edi_oca-missing_fwp
branch
from
October 24, 2024 08:03
04bafd6
to
1dca94e
Compare
Instead of waiting for the cron to pass again and send the file chain the 2 jobs so that it gets sent right after generation.
* catch OSError * add debug log
JordiMForgeFlow
force-pushed
the
17.0-imp-edi_oca-missing_fwp
branch
2 times, most recently
from
October 24, 2024 08:31
089c8d1
to
5eb1331
Compare
This was referenced Oct 24, 2024
JordiMForgeFlow
force-pushed
the
17.0-imp-edi_oca-missing_fwp
branch
from
October 24, 2024 09:20
5eb1331
to
9126022
Compare
Prevents having duplicated jobs for the same record as far as possible.
Try to send out the file as fast as possible once the content is ready.
The origin record should never been copied. Its values should always be set specifically by a framework action.
this field can be used in backend views to show/hide configuration elements depending on the backend type
Currently when we receive an empty file: - Receive step doesn't end up in state error_on_receive : that's because we just ignore the content here - But the process step will raise an error - So this commit goal tries to improve that - By default, this option is disabled so we still consider that an empty file is an error case
JordiMForgeFlow
force-pushed
the
17.0-imp-edi_oca-missing_fwp
branch
from
October 24, 2024 09:30
9126022
to
de20b96
Compare
@simahawk @etobella @MiquelRForgeFlow ready for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the migration to V17 several commits were left behind in V16.
Depends on OCA/queue#705
CC @etobella @simahawk