Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] delivery_roulier: fix AttributeError...is_roulier #895

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] delivery_roulier: fix AttributeError...is_roulier #895

wants to merge 1 commit into from

Conversation

imlopes
Copy link

@imlopes imlopes commented Oct 22, 2024 

self.carrier_id.with_context(order_weight=self.total_weight).rate_shipment(self.order_id)
  File "/odoo/external-src/delivery-carrier/delivery_roulier/models/delivery_carrier.py", line 47, in rate_shipment
    if not res and self.is_roulier():
AttributeError: 'delivery.carrier' object has no attribute 'is_roulier'

@OCA-git-bot
Copy link
Contributor

Hi @florian-dacosta,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis added this to the 17.0 milestone Oct 24, 2024
@rousseldenis
Copy link
Contributor

@imlopes Thanks for this. Isn't it possible to add a test that return nothing for super() in rate_shipment() in order to avoid future regressions ?

SilvioC2C
SilvioC2C reviewed Oct 25, 2024
View reviewed changes
delivery_roulier/models/delivery_carrier.py
res = {
"success": True,
"price": 0.0,
"carrier_price": 0.0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilvioC2C SilvioC2C SilvioC2C left review comments

@yankinmax yankinmax yankinmax approved these changes

Assignees
No one assigned
Labels
enhancement needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@imlopes @OCA-git-bot @rousseldenis @yankinmax @SilvioC2C