Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] currency_rate_update_xe #191

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

mpascuall
Copy link
Contributor

Module migrated to version 14.0

cc https://github.com/APSL 153469

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review

Copy link

@javierobcn javierobcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Ok, checked in runboat

@pedrobaeza pedrobaeza added this to the 14.0 milestone Mar 26, 2024
@mpascuall mpascuall changed the title [14.0][MIG] <currency_rate_update_xe>: Migration to 14.0. 14.0 MIG <currency_rate_update_xe>: Migration to 14.0. Mar 26, 2024
@mpascuall mpascuall changed the title 14.0 MIG <currency_rate_update_xe>: Migration to 14.0. [14.0][MIG] currency_rate_update_xe Mar 26, 2024
Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on the Runboat

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the migration commit message properly with the module name, that is missing.

@mpascuall mpascuall force-pushed the 14.0-mig-currency_rate_update_xe branch from 3dadd6f to 55eb46b Compare April 5, 2024 09:59
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-191-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 5902f1f into OCA:14.0 Apr 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3c95a5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants