Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] currency_rate_update: Migration to 17.0 #189

Closed
wants to merge 154 commits into from

Conversation

quoc-pn
Copy link
Member

@quoc-pn quoc-pn commented Nov 21, 2023

No description provided.

jgrandguillaume and others added 30 commits November 21, 2023 15:31
(lp:c2c-addons/6.1  rev 1.1.3)
(lp:c2c-addons/6.1  rev 1.1.77)
(lp:c2c-addons/6.1  rev 1.2.14)
(lp:c2c-addons/6.1  rev 1.5.1)
(lp:c2c-addons/6.1  rev 1.5.15)
(lp:c2c-addons/6.1  rev 12)
(lp:c2c-addons/6.1  rev 13.1.1)
(lp:c2c-addons/6.1  rev 17)

[FIX] currency_rate_update - change on_changes in non private methods
(lp:c2c-addons/6.1  rev 18)
(lp:c2c-addons/6.1  rev 19.1.1)
(lp:c2c-addons/6.1  rev 22)
(lp:c2c-addons/6.1  rev 24.1.1)
(lp:c2c-addons/6.1  rev 24.1.3)
…report_webkit to 6.1 : API changes of 6.1, mainly the change of osv.memory now stored in DB, we should now have _columns, we can not rely anymore only on fields_view_get. Also shorten name files and wizard model names.

(lp:c2c-addons/6.1  rev 28)
(lp:c2c-addons/6.1  rev 49)

[FIX] spelling
(lp:c2c-addons/6.1  rev 77)
…e reactivated when the modules are migrated

[FIX] encoding should be coding
[IMP] hiding company_id field as always used within company form

[FIX]using logging instead of netscv

[FIX] imports

[FIX] use osv.Model

[DEL] remove unused wizard directory

[FIX] loading xml files

[FIX] parameter name

[IMP] copyright headers

[IMP] logging arguments
[IMP] clean spaces

[IMP] change license to AGPL
Ivorra78 and others added 6 commits November 21, 2023 15:31
Currently translated at 100.0% (75 of 75 strings)

Translation: currency-16.0/currency-16.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-16-0/currency-16-0-currency_rate_update/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: currency-16.0/currency-16.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-16-0/currency-16-0-currency_rate_update/
Currently translated at 100.0% (74 of 74 strings)

Translation: currency-16.0/currency-16.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-16-0/currency-16-0-currency_rate_update/fr/
Currently translated at 94.5% (70 of 74 strings)

Translation: currency-16.0/currency-16.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-16-0/currency-16-0-currency_rate_update/nl/
Currently translated at 100.0% (74 of 74 strings)

Translation: currency-16.0/currency-16.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-16-0/currency-16-0-currency_rate_update/zh_CN/
@quoc-pn quoc-pn force-pushed the 17.0-mig-currency_rate_update branch from e2dd47b to 1f9237e Compare November 21, 2023 08:58
@quoc-pn quoc-pn marked this pull request as ready for review November 21, 2023 09:01
Copy link

@hieulucky111 hieulucky111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.
LGTM

currency_rate_update/README.rst Show resolved Hide resolved
Copy link

@cuongnmtm cuongnmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a separate commit for "pre-commit auto fixes" following this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why you commit this file

@quoc-pn quoc-pn force-pushed the 17.0-mig-currency_rate_update branch from 1f9237e to 382d90b Compare November 21, 2023 09:26
@quoc-pn quoc-pn mentioned this pull request Nov 21, 2023
3 tasks
Copy link

@cuongnmtm cuongnmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration currency_rate_update

@OCA-git-bot OCA-git-bot modified the milestone: 17.0 Nov 26, 2023
@quoc-pn quoc-pn force-pushed the 17.0-mig-currency_rate_update branch from 382d90b to 504b61c Compare November 27, 2023 02:44
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-189-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f476c1a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.