[16.0] [ADD] recurring_payment_stripe module #1151
Conversation
[16.0][ADD] recurring_payments_stripe: Add recurring payments with stripe
[16.0][ADD] recurring_payments_stripe: Add stripe library
| metadata={"odoo_invoice_id": str(invoice.id)}, | ||
| ) | ||
|
|
||
| # Manejar el resultado del PaymentIntent |
There was a problem hiding this comment.
Fixed translation problem in the comment
| { | ||
| "name": "Recurring Payments with Stripe", | ||
| "version": "16.0.1.0.0", | ||
| "summary": """ Recurring Payments with Stripe """, |
There was a problem hiding this comment.
Not sure about the spacing before and after the """.
There was a problem hiding this comment.
Fixed spaces before and after within summary content
|
Module name shouldn't contain plurals. Coupling this also to subscription module doesn't seem modular. A base module with the API, and another for linking with subscriptions is a better design. |
There was a problem hiding this comment.
I have reviewed the addon, and it appears to be functioning well. However, I’ve noticed that while the payment for the first invoice related to the subscription is being correctly recorded, the corresponding entries are not being created in the payment_transaction table for subsequent invoices. While the payment for the first invoice shows up as expected, the payment transactions for the following invoices are not being registered in payment_transaction.
Agree |
mjavint
changed the title
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation
…pe' into 16.0-dev
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation * [FIX] Fixed test implementation
…pe' into 16.0-dev
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation
…pe' into 16.0-dev
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation
…pe' into 16.0-dev
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed precommit
…pe' into 16.0-dev
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed precommit * [FIX] Fixed implementation
* [FIX] Fixed payment transaction and design modular * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed test implementation * [FIX] Fixed precommit * [FIX] Fixed implementation
…pe' into 16.0-dev
mjavint
force-pushed
the
16.0-add-recurring_payments_stripe
branch
2 times, most recently
from
0b00b1c to
5329d7c
Compare
# This is the 1st commit message: [FIX] Fixed recurring payments # This is the commit message #2: [FIX] Resolved all suggestion # This is the commit message #3: [ADD] Add precommit rules # This is the commit message #4: [ADD] Add stripe library # This is the commit message #5: [ADD] Add stripe library # This is the commit message #6: [FIX] Fixed precommit error # This is the commit message #7: [FIX] Fixed precommit error # This is the commit message #8: [FIX] Fixed precommit flake error # This is the commit message #9: [FIX] Fixed translation error in account_move.py and spaces inside summary # This is the commit message #10: [FIX] Fixed translation error in account_move.py and spaces inside summary # This is the commit message #11: [FIX] Fixed payment transaction and design modular # This is the commit message #12: [FIX] Fixed test implementation
mjavint
force-pushed
the
16.0-add-recurring_payments_stripe
branch
from
db7f883 to
4a83366
Compare
Add recurring payments with stripe