-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_bank_statement_chatter: Migration to 16.0 #1869
[16.0][MIG] account_bank_statement_chatter: Migration to 16.0 #1869
Conversation
2e27c62
to
564e1fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cubells I understand you were maintainer of this module on 12.0. Is this OK for you to merge? |
@pedrobaeza is this Ok for merge? |
Why not including this in |
@pedrobaeza Basically, in I personally think is better to maintain the inheriting in this module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1869-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot migration account_bank_statement_chatter |
Please rebase and check pre-commit. |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_bank_statement_chatter Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_bank_statement_chatter/
564e1fa
to
cc8331a
Compare
cc8331a
to
8f044c0
Compare
@pedrobaeza rebase and pre-commit applied |
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 59159eb. Thanks a lot for contributing to OCA. ❤️ |
Migration to 16.0 account_bank_statement_chatter module.