Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_bank_statement_chatter: Migration to 16.0 #1869

Merged
merged 7 commits into from
Oct 7, 2024
Merged

[16.0][MIG] account_bank_statement_chatter: Migration to 16.0 #1869

merged 7 commits into from
Oct 7, 2024

Conversation

sergiobstoj
Copy link
Member

@sergiobstoj sergiobstoj commented Apr 23, 2024 •
edited
Loading

Migration to 16.0 account_bank_statement_chatter module.

@sergiobstoj sergiobstoj force-pushed the 16.0-mig-account_bank_statement_chatter branch from 2e27c62 to 564e1fa Compare April 23, 2024 08:55
@sergiobstoj sergiobstoj changed the title [WIP][16.0][MIG] mig account bank statement chatter [16.0][MIG] mig account bank statement chatter Apr 25, 2024
@sergiobstoj sergiobstoj marked this pull request as ready for review April 25, 2024 08:50
@sergiobstoj sergiobstoj mentioned this pull request Apr 30, 2024
Closed
@sergiobstoj sergiobstoj changed the title [16.0][MIG] mig account bank statement chatter [16.0][MIG] account_bank_statement_chatter: Migration to 16.0 Jul 29, 2024
MayteGLC
MayteGLC approved these changes Aug 1, 2024
View reviewed changes
Copy link

@MayteGLC MayteGLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiobstoj
Copy link
Member Author

@cubells I understand you were maintainer of this module on 12.0. Is this OK for you to merge?

@sergiobstoj
Copy link
Member Author

@pedrobaeza is this Ok for merge?

@pedrobaeza
Copy link
Member

Why not including this in account_statement_base?

@sergiobstoj
Copy link
Member Author

@pedrobaeza Basically, in account_statement_base, model account.bank.statement is not inheriting from mail.thread and mail.activity.mixin.

I personally think is better to maintain the inheriting in this module.

pedrobaeza
pedrobaeza approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1869-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 4, 2024
@OCA-git-bot
Merge PR #1869 into 16.0
7775433 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1869-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot migration account_bank_statement_chatter

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 4, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 4, 2024
Open
33 tasks
@pedrobaeza
Copy link
Member

Please rebase and check pre-commit.

@sergiobstoj sergiobstoj force-pushed the 16.0-mig-account_bank_statement_chatter branch from 564e1fa to cc8331a Compare October 7, 2024 09:50
@sergiobstoj sergiobstoj force-pushed the 16.0-mig-account_bank_statement_chatter branch from cc8331a to 8f044c0 Compare October 7, 2024 09:52
@sergiobstoj
Copy link
Member Author

@pedrobaeza rebase and pre-commit applied

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1869-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6176bf9 into OCA:16.0 Oct 7, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 59159eb. Thanks a lot for contributing to OCA. ❤️

@sergiobstoj sergiobstoj deleted the 16.0-mig-account_bank_statement_chatter branch October 8, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@aritzolea aritzolea aritzolea approved these changes

@MayteGLC MayteGLC MayteGLC approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@sergiobstoj @pedrobaeza @OCA-git-bot @aritzolea @MayteGLC @cubells @oca-travis @weblate