[17.0][MIG] account_check_deposit #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean code * Add access rules for account_check_deposit * Change print button name
* [FIX] fix datamodel structure, indeed check_payment_ids should be a m2o. In the view we still keep the widget * [REF] remove useless state cancel, only draft/done is sufficent for now, forbid to delete a done deposit, fix move_line name need to be the equal to the line.ref for the reconciliation * [IMP] improve reconciliation between the check and the check deposit * [FIX] set correctly the date on the move line generated * [FIX] fix reconciliation of check * [IMP] check deposit improve view and add tab for move line generated * [IMP] add total amount and flag to know if the deposit have been reconcile, the best will be to add a workflow * [FIX] fix error when replaying commit * [REF] remove dependency on sale_quick_payment as check can be registred in various way like native voucher * [CLEAN] pep8 cleanup no code change * [REF] clean remove useless code, default value are called during the create * [FIX] fix wrong spelling * [REF] V7 clean up
Works with a single account journal Usability and many other enhancements
… for the payment, one for the deposit), hide unreconcile entry which a link to a deposit
Convert webkit report to qweb
* Move description from __openerp__.py to README.rst * Move files in sub-directories * FIX access rights issue when user was not accounting manager OCA Transbot updated translations from Transifex
* create move and move line at the same time * add tests
* Add option to have the counter-part of the deposit move directly to the bank account Use account.config.settings page * Remove data that create a bank journal because it blocks the loading of the chart of accounts when the module is installed at the same time as the chart of account (via dependencies) OCA Transbot updated translations from Transifex
…rnal if the offsetting account is the bank account OCA Transbot updated translations from Transifex
For avoiding constraint. [UPD] Update account_check_deposit.pot
[UPD] Update account_check_deposit.pot [UPD] README.rst
Currently translated at 100,0% (61 of 61 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_check_deposit/de/ Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Add print button (feature up-ported from v10) Add option to post moves (feature up-ported from v10) Sequence now takes into account the deposit date Customize the filename of the report Update README with v12 labels [UPD] README.rst [UPD] Update account_check_deposit.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/ [UPD] README.rst
Currently translated at 100.0% (63 of 63 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/pt/
Currently translated at 100.0% (63 of 63 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/pt/
Currently translated at 100.0% (63 of 63 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_check_deposit/pt/
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_check_deposit/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_check_deposit/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_check_deposit/
Currently translated at 100.0% (89 of 89 strings) Translation: account-financial-tools-15.0/account-financial-tools-15.0-account_check_deposit Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-15-0/account-financial-tools-15-0-account_check_deposit/es_AR/
In v16, if we create the account.move and then the account.move.line one-by-one, we end up with an additionnal line with credit=debit=0 and label="Automatic balancing line". So I decided to re-write move generation and simplify the move of the check deposit: no need to have one move line per check, we can have a single line for the total of checks without partner and reconcile this single line with all the checks.
Add an error message in case of configuration error Use official translate method for multi-string replacements in error messages
…osits Add confirm pop-up when clicking on "Back to draft"
Fix a few strings
Migration from v16 to v17 Convert read_group to _read_group() for perf improvements
alexis-via
force-pushed
the
17-mig-account_check_deposit
branch
from
77ab111
to
52ea827
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Sep 28, 2024
|
@alexis-via your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1809-by-alexis-via-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a53469e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.