Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay documentation #115

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Overlay documentation #115

merged 4 commits into from
Nov 27, 2024

Conversation

lornajane
Copy link
Collaborator

Fixes #112 , adding some documentation for users of Overlays.

@lornajane lornajane marked this pull request as ready for review November 27, 2024 09:41
Copy link
Collaborator

@SensibleWood SensibleWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lornajane looks like a very useful set of examples. Left a couple of suggestions, but nothing massive. Left as comments, feel free to incorporate or ignore.

overlay/index.md Outdated Show resolved Hide resolved
overlay/example-add-filter-parameters.md Outdated Show resolved Hide resolved
overlay/example-add-filter-parameters.md Outdated Show resolved Hide resolved
@lornajane
Copy link
Collaborator Author

Another related issue OAI/Overlay-Specification#34

overlay/index.md Outdated Show resolved Hide resolved
overlay/example-add-license.md Outdated Show resolved Hide resolved
overlay/example-add-filter-parameters.md Outdated Show resolved Hide resolved
@lornajane lornajane requested a review from ralfhandl November 27, 2024 16:35
Copy link
Collaborator

@SensibleWood SensibleWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updates look great. It's a yes from me 👍

@lornajane lornajane merged commit c5e3673 into OAI:main Nov 27, 2024
@lornajane lornajane deleted the overlay-docs branch November 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlays examples and content
3 participants