Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.x: the hopefully last two typos #87

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

1.x: the hopefully last two typos #87

wants to merge 1 commit into from

Conversation

ralfhandl
Copy link
Contributor

No description provided.

@ralfhandl ralfhandl added this to the Release 1.0 milestone Oct 21, 2024
@ralfhandl ralfhandl mentioned this pull request Oct 21, 2024
Merged
mikekistler
mikekistler approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl requested a review from a team October 22, 2024 06:58
@lornajane lornajane marked this pull request as draft October 22, 2024 15:24
@ralfhandl ralfhandl modified the milestones: Release 1.0, Release 2.0 Oct 22, 2024
@lornajane
Copy link
Contributor

Two things here:

  • This should be in a future patch release, so 1.0.1 or something like that, we won't update the 1.0.0 spec contents now.
  • This repo needs a branching strategy and documentation to go with it, and then we'll rebase this PR and use it as a target demo.

@ralfhandl ralfhandl modified the milestones: Release 2.0, Release 1.0 Oct 22, 2024
@lornajane lornajane changed the title 1.0.0: the hopefully last two typos 1.x: the hopefully last two typos Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@kevinswiber kevinswiber Awaiting requested review from kevinswiber

@lornajane lornajane Awaiting requested review from lornajane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ralfhandl @lornajane @mikekistler