Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build script: example links point to HTML wrapper on learn site #4033

Merged
merged 5 commits into from
Aug 22, 2024
Merged

build script: example links point to HTML wrapper on learn site #4033

merged 5 commits into from
Aug 22, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 16, 2024 •
edited
Loading

  • example links point to HTML wrapper on learn site
  • npm test (and thus the schema-test workflow) will complain if test coverage drops
  • added comment to md2html.js explaining that the anchor tweak is needed for older spec versions

Depends on

@ralfhandl ralfhandl requested review from a team as code owners August 16, 2024 07:53
@ralfhandl ralfhandl added Housekeeping script Pull requests that update Bash or JavaScript code javascript Pull requests that update Javascript code labels Aug 16, 2024
@ralfhandl ralfhandl changed the title require full code coverage (for now) build script: example links point to HTML wrapper on learn site Aug 16, 2024
@ralfhandl ralfhandl mentioned this pull request Aug 16, 2024
Closed
lornajane
lornajane approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@lornajane lornajane merged commit c754de0 into OAI:main Aug 22, 2024
2 checks passed
@ralfhandl ralfhandl deleted the main-script-tweaks branch August 22, 2024 16:25
@ralfhandl ralfhandl mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornajane lornajane lornajane approved these changes

@handrews handrews Awaiting requested review from handrews

Assignees
No one assigned
Labels
Housekeeping javascript Pull requests that update Javascript code script Pull requests that update Bash or JavaScript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralfhandl @lornajane