Release 0.1.1 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 31, 2019 14:38
As Ruby >= 2.4 enforces a 32 byte string length
vprigent
reviewed
Feb 12, 2019
| @@ -1,3 +1,3 @@ | |||
| module ClaimToken | |||
| VERSION = "0.1.0" | |||
| VERSION = "0.1.1".freeze | |||
There was a problem hiding this comment.
Do we actually need to specify freeze now ? I though this was being automatically done by ruby ?
There was a problem hiding this comment.
According to this stack overflow discussion you should do this or add the frozen string literal magic comment until Ruby 3, in which it'd do this by default https://stackoverflow.com/a/37799399
vprigent
reviewed
Mar 27, 2019
| end | ||
| end | ||
|
|
||
| def use_test_configuration | ||
| before do | ||
| ClaimToken.configure do |config| | ||
| config.shared_encryption_key = "uFeb25D_z0BAGhgH7WKy8QBSat6kxfDa6PrKw1ox69U=" | ||
| config.shared_encryption_key = "fba0d989f259ad36ada12c127356d420" | ||
| config.digest_secret = "d22b90c9172649eaf49cd185f73bd4a53ec3ff4dc6f7d51f9dbaac62421e6dd297b38efcd431a7f2" |
There was a problem hiding this comment.
This key is still 64 bits long, no potential issue there ?
vprigent
approved these changes
Aug 22, 2019
dznz
reviewed
Jan 14, 2020
| @@ -6,7 +6,7 @@ require 'claim_token/version' | |||
| Gem::Specification.new do |spec| | |||
| spec.name = "claim_token" | |||
| spec.version = ClaimToken::VERSION | |||
| spec.authors = ["CricHQ"] | |||
| spec.authors = ["Daniel Zollinger", "Ben Greville"] | |||
There was a problem hiding this comment.
Aww this lil library still getting love 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch release allows for Ruby 2.4 and higher OpenSSL support, which enforces a 32 byte string length encryption key.
Existing applications using this gem that are encrypting tokens using the correct length string can continue running the older versions.
This patch also removes a deprecation warning described here: attr-encrypted/attr_encrypted#264
Fixes: #6